This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 378
[benchmarks] Update weights for bridge-hubs #2242
Merged
joepetrowski
merged 1 commit into
release-parachains-v9380
from
weights-bridge-hubs-release-parachains-v9380-1677503250
Feb 28, 2023
Merged
[benchmarks] Update weights for bridge-hubs #2242
joepetrowski
merged 1 commit into
release-parachains-v9380
from
weights-bridge-hubs-release-parachains-v9380-1677503250
Feb 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
reviewed
Feb 27, 2023
// Standard Error: 5 | ||
.saturating_add(Weight::from_ref_time(2_009).saturating_mul(b.into())) | ||
// Minimum execution time: 6_103 nanoseconds. | ||
Weight::from_ref_time(6_305_000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its back to "normal"
bkontur
reviewed
Feb 27, 2023
// Standard Error: 3 | ||
.saturating_add(Weight::from_ref_time(2_056).saturating_mul(b.into())) | ||
// Minimum execution time: 6_395 nanoseconds. | ||
Weight::from_ref_time(135_959_306) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but here is too much 22x
bkontur
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, except that remark_with_event 20x
https://github.com/paritytech/cumulus/pull/2242/files#diff-cb7970b78a34a7756ff29a11195ce685cc486f774bdfaf0b41a860fb05ae1f84R66
EgorPopelyaev
requested review from
joepetrowski,
tonyalaribe,
EgorPopelyaev,
gilescope and
a team
February 27, 2023 14:14
EgorPopelyaev
added
B0-silent
Changes should not be mentioned in any release notes
T9-release
This PR/Issue is related to topics touching the release notes.
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Feb 27, 2023
EgorPopelyaev
approved these changes
Feb 27, 2023
joepetrowski
deleted the
weights-bridge-hubs-release-parachains-v9380-1677503250
branch
February 28, 2023 14:48
EgorPopelyaev
pushed a commit
that referenced
this pull request
Mar 1, 2023
Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Mar 1, 2023
Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
joepetrowski
pushed a commit
that referenced
this pull request
Mar 1, 2023
* [benchmarks] pr with weights (#2244) Co-authored-by: paritytech-ci <paritytech-ci@parity.io> * [benchmarks] pr with weights (#2242) Co-authored-by: paritytech-ci <paritytech-ci@parity.io> * [benchmarks] pr with weights (#2241) Co-authored-by: paritytech-ci <paritytech-ci@parity.io> --------- Co-authored-by: Paritytech CI <52199148+paritytech-ci@users.noreply.github.com> Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
joepetrowski
pushed a commit
that referenced
this pull request
Mar 1, 2023
* [benchmarks] pr with weights (#2244) Co-authored-by: paritytech-ci <paritytech-ci@parity.io> * [benchmarks] pr with weights (#2242) Co-authored-by: paritytech-ci <paritytech-ci@parity.io> * [benchmarks] pr with weights (#2241) Co-authored-by: paritytech-ci <paritytech-ci@parity.io> --------- Co-authored-by: Paritytech CI <52199148+paritytech-ci@users.noreply.github.com> Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
bkontur
added a commit
that referenced
this pull request
Jul 4, 2023
0417308a48 Update docs (#2242) 1a0d3b55f3 Nits for subtree (#2241) 18fca2e122 Ensure that the origin is signed for submit_parachain_heads and submit_finality_proof calls (#2239) fab51067e7 minor doc fix (#2207) 4feb721d32 backport cumulus changes to polkadot-staging (#2167) 433741942a fix testnet argocd deploy (#2151) (#2152) ff9eadc7dc Updated BHR/W version + codegen (#2148) git-subtree-dir: bridges git-subtree-split: 0417308a489096979ed3e08d0f8caafbfca6e7e9
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Jul 4, 2023
* BH subtree master -> polkadot-staging by default * Squashed 'bridges/' changes from c9dd8b9dfc..0417308a48 0417308a48 Update docs (#2242) 1a0d3b55f3 Nits for subtree (#2241) 18fca2e122 Ensure that the origin is signed for submit_parachain_heads and submit_finality_proof calls (#2239) fab51067e7 minor doc fix (#2207) 4feb721d32 backport cumulus changes to polkadot-staging (#2167) 433741942a fix testnet argocd deploy (#2151) (#2152) ff9eadc7dc Updated BHR/W version + codegen (#2148) git-subtree-dir: bridges git-subtree-split: 0417308a489096979ed3e08d0f8caafbfca6e7e9 * Fix deps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
T9-release
This PR/Issue is related to topics touching the release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is generated automatically by CI.
Compare the weights with
release-parachains-v9380
: https://weights.tasty.limo/compare?repo=cumulus&threshold=30&path_pattern=**%2Fweights%2F*.rs&method=guess-worst&ignore_errors=true&unit=time&old=release-parachains-v9380&new=weights-bridge-hubs-release-parachains-v9380-1677503250