This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix for xcm-emulator - Wrong Parachain processing message
#2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoPal
added
B0-silent
gilescope
approved these changes
Jun 30, 2023
muharem
approved these changes
Jul 2, 2023
|
bot merge |
NachoPal
added a commit
that referenced
this pull request
Jul 3, 2023
* fix * forgot para_id * remove unreachable code
NachoPal
added a commit
that referenced
this pull request
Jul 3, 2023
* fix * forgot para_id * remove unreachable code
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Xcm Emulator: prepare XCMP on init (#2711) * std for pallet-glutton * fix xcm-emulator init * headers for it tests * Fix for `xcm-emulator` - Wrong Parachain processing message (#2800) * fix * forgot para_id * remove unreachable code * remove glutton dep --------- Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Xcm Emulator: prepare XCMP on init (#2711) * std for pallet-glutton * fix xcm-emulator init * headers for it tests * remove glutton dep * Fix for `xcm-emulator` - Wrong Parachain processing message (#2800) * fix * forgot para_id * remove unreachable code --------- Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
girazoki
pushed a commit
to moondance-labs/cumulus
that referenced
this pull request
Aug 11, 2023
…ritytech#2810) * Xcm Emulator: prepare XCMP on init (paritytech#2711) * std for pallet-glutton * fix xcm-emulator init * headers for it tests * remove glutton dep * Fix for `xcm-emulator` - Wrong Parachain processing message (paritytech#2800) * fix * forgot para_id * remove unreachable code --------- Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the condition to process messages by a Parachain is incomplete.
We did not notice because of the coincidence that for all our tests, the destination Parachain that is supposed to receive/process the message, had been declared always before the other Parachains.
Example of failing case:
We send a message to
PenpalPolkadot. The message will never reach its destination becauseAssetHubPolkadotwill try to process it first as it is a message to the sameNetworkAssetHubPolkadotandPenpalPolkadotlive.Same test would pass just switching Parachains order declarations.
Solution: filter also by
para_idand not only byNetwork.