This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[benchmarks] Update weights for collectives #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorPopelyaev
added
B0-silent
EgorPopelyaev
requested review from
gilescope,
jsidorenko,
muharem,
bkontur,
NachoPal,
joepetrowski and
alvicsam
joepetrowski
approved these changes
Jul 22, 2023
gilescope
reviewed
Jul 24, 2023
parachains/runtimes/collectives/collectives-polkadot/src/weights/frame_system.rs
Show resolved
Hide resolved
gilescope
reviewed
Jul 24, 2023
| // Measured: `119 + b * (32 ±0)` | ||
| // Estimated: `6287` | ||
| // Minimum execution time: 15_915_000 picoseconds. | ||
| Weight::from_parts(16_219_185, 0) |
There was a problem hiding this comment.
was 200million before. Curious how we have got a lot more efficient... or is this the effects of switching to the VM benchmark machines?
There was a problem hiding this comment.
Ah these are the new functions that giulia worked on. Ok that fine then. 16m seems a more reasonable weight.
There was a problem hiding this comment.
gilescope
approved these changes
Jul 24, 2023
|
bot merge |
paritytech-processbot
bot
deleted the
weights-collectives-release-parachains-v10000-1689947901
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is generated automatically by CI.
Compare the weights with
release-parachains-v10000: https://weights.tasty.limo/compare?repo=cumulus&threshold=30&path_pattern=**%2Fweights%2F*.rs&method=guess-worst&ignore_errors=true&unit=time&old=release-parachains-v10000&new=weights-collectives-release-parachains-v10000-1689947901