This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 379
Remove All Assets and Uniques from NonTransfer
Proxy
#486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not really directly related but I am thinking if it make sense to introduce an event based proxy filtering mechanism. i.e. fail the transaction if a specific event is emitted. |
@xlc would only work for transactional extrinsics? |
Right. So that't depends on making everything |
bkchr
approved these changes
Jun 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unique is not in statemint and westmint?
bot merge |
Trying merge. |
ghost
deleted the
shawntabrizi-proxy-filter-update
branch
June 16, 2021 23:02
chevdor
pushed a commit
to chevdor/cumulus
that referenced
this pull request
Jun 24, 2021
* remove all assets and uniques from `NonTransfer` proxy * fix merge
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the nature of the Assets and Uniques pallet, it seems very sensible to disable all access to this pallets from the
NonTransfer
proxy.Combinations of calls like
mint
andburn
can be used to emulate transfer behaviors, and who knows what new functions will be added.Given that we have explicit Proxies for
AssetOwner
andAssetManager
, which specifically handle management of these pallets, I see little reason forNonTransfer
proxy to have this risk.Fixes: https://github.com/paritytech/srlabs_findings/issues/91