Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate commits with Round and generate commits under new equivocation rules #39

Merged
merged 3 commits into from
Jan 11, 2019
Merged

Validate commits with Round and generate commits under new equivocation rules #39

merged 3 commits into from
Jan 11, 2019

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Jan 4, 2019

Closes #37

We now generate commits with any votes targeting the chain or any equivocations (as they count for everything).

We could be a bit more clear about the preconditions/param ownership of validate_commit but that's a bit beyond the scope here.

@rphmeier rphmeier requested a review from andresilva January 4, 2019 19:09
andresilva
andresilva approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/lib.rs Outdated Show resolved Hide resolved
@andresilva @rphmeier
Update src/lib.rs
ed65327 
Co-Authored-By: rphmeier <rphmeier@gmail.com>
@andresilva andresilva merged commit daba44d into master Jan 11, 2019
@andresilva andresilva deleted the rh-commit-with-round branch June 13, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
A0-pleasereview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rphmeier @andresilva