Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "ahash-compile-time-rng" feature in hashbrown. #90

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Nov 16, 2019

This will ensure that every build uses the same ahash seed, instead of a compile-time randomized one (which is now the default - see rust-lang/hashbrown#124, rust-lang/hashbrown#125, tkaitchuck/aHash#18 and tkaitchuck/aHash#25 for more details/background).

(The other such update PR needed is paritytech/trie#36).

@parity-cla-bot
Copy link

It looks like @eddyb signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e00b623). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #90   +/-   ##
=========================================
  Coverage          ?   88.47%           
=========================================
  Files             ?       10           
  Lines             ?     3114           
  Branches          ?        0           
=========================================
  Hits              ?     2755           
  Misses            ?      359           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00b623...70e762c. Read the comment docs.

@rphmeier rphmeier merged commit 57d2298 into paritytech:master Nov 18, 2019
@eddyb eddyb deleted the derandomize branch November 18, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants