Add EVM to Revive bytecode migration #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexggh
approved these changes
Oct 10, 2025
| let current_nonce = System::account_nonce(&account_id); | ||
|
|
||
| // Convert EVM balance to PVM balance with precision handling | ||
| // TODO: needs to be replaced with `set_evm_balance`` once new pallet-revive is used |
Collaborator
Author
There was a problem hiding this comment.
the functionality was there, but I needed to fix it, so the change is on master now
| }) | ||
| }); | ||
| } | ||
| // TODO handle immutables |
There was a problem hiding this comment.
The APIs to access the immutables are already in master, can't you add that as well ? OR you plan to do it as follow up.
Collaborator
Author
There was a problem hiding this comment.
It is needed for evm from pallet revive, which we do not support yet
|
|
||
| vm.pvm(true); | ||
|
|
||
| // TODO: Enable after contract storage migration is on place |
Collaborator
Author
There was a problem hiding this comment.
It will be a separate PR for this
pkhry
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #343