Metadata V15: Add outer enum types for calls, events, errors #57
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
| @@ -50,6 +50,12 @@ pub struct RuntimeMetadataV15 { | |||
| pub ty: <PortableForm as Form>::Type, | |||
| /// Metadata of the Runtime API. | |||
| pub apis: Vec<RuntimeApiMetadata<PortableForm>>, | |||
| /// The type of the outer `RuntimeCall` enum. | |||
| pub call_enum_ty: <PortableForm as Form>::Type, | |||
There was a problem hiding this comment.
By doing this, we now have duplicated data in the metadata... I'm for this change, but then we should remove the duplicated stuff, like pallet.error, pallet.calls etc.
There was a problem hiding this comment.
Indeed. I did have these originally and removed them on the grounds of duplication, favouring the previous structure of pallet.calls etc. for ease of migration. But if it will be a new breaking metadata version then we can consider removing them.
There was a problem hiding this comment.
Technically we change the encoded format, so it will always require a new metadata version. However, we are in the process of releasing the next metadata version any way.
There was a problem hiding this comment.
That makes, sense. I'll create another PR to remove the duplicate data (ie pallet. calls) for the V15, thanks!
There was a problem hiding this comment.
Please post this into the Polkadot forum. We need some attention around this.
There was a problem hiding this comment.
Can go into the post of @jsdw where he announced the V15 freeze.
| /// The type of the outer `RuntimeEvent` enum. | ||
| pub event_enum_ty: <PortableForm as Form>::Type, | ||
| /// The type of the outer `RuntimeError` enum. | ||
| pub error_enum_ty: <PortableForm as Form>::Type, |
There was a problem hiding this comment.
And you know that the error type isn't encoded like this? I know that you introduced this type now, but it doesn't make that much sense....
This PR adds the outer enum types to the metadata:
For more info visit: paritytech/substrate#14143
// CC @paritytech/subxt-team