This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Rename build target macos => darwin #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
pushed a commit
to niklasad1/hidapi-rs
that referenced
this pull request
Feb 23, 2019
Selectable backends
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.rstargetmacoslooks obsolete. Now it returnsx86_64-apple-darwin. I'm able to reproduce this both on my laptop and travis-ci. So maybe it's time to change it.The simple way to reproduce the issue is by cloning this repo and running
cargo test. Travis tests were also broken.The target mismatch affects on using ethcore crate with distinct projects. I described this in the issue openethereum/parity-ethereum#8407