This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Post contract size diff to parent PR #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
approved these changes
Nov 16, 2021
| csv-comparator $BASELINE_FILE $COMPARISON_FILE | \ | ||
| sort | \ | ||
| awk -F"," '{printf "`%s`,%.2f kb,%.2f kb\n", $1, $2, $3}' | \ | ||
| sed --regexp-extended 's/^([0-9])/,+\1/g' | \ |
There was a problem hiding this comment.
What's this doing? My regex brain is too smol
There was a problem hiding this comment.
Prepends a plus in front of positive numbers. Yeah we could definitely move all of this into csv-comparator. I added a comment as well.
| # Append the original optimized size (i.e. not the delta) to the end of each line | ||
| cat $COMPARISON_FILE | \ | ||
| sort | uniq | \ | ||
| egrep --only-matching ', [0-9]+\.[0-9]+$' | \ |
There was a problem hiding this comment.
I wonder if maybe we should install ripgrep in our CI Docker image, might make some of this stuff more readable
| sed --regexp-extended 's/(-+)\:/:\1/' | \ | ||
| sed 's/$/\\n/g' | \ | ||
| tr -d '\n' | \ | ||
| tee contract-size-diff-nl.md |
There was a problem hiding this comment.
newline, I changed the name.
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final step for closing #4 after prior work by @HCastano.
Example of how it looks.
Ideally we would move the number-formatting stuff into
csv-comparator, but that can be done in a follow-up if someone feels like it.