Fix bug not showing dappIcon #29
Conversation
amaury1093
commented
Dec 18, 2017
•
amaury1093
commented
- Fix bug of dappIcons not showing
- Remove imageRef when hiding broken images, use CSS class instead
src/DappIcon/dappIcon.js
Outdated
| switch (app.type) { | ||
| case 'view': { | ||
| const fallbackSrc = | ||
| window.location.protocol === 'file:' ? `dapps/${app.id}/icon.png` : `${dappHost}/dapps/${app.id}/icon.png`; |
There was a problem hiding this comment.
@jacogr Can you confirm that we are not using file:// anymore?
In that case I'll just put fallbackSrc = ${dappHost}/dapps/${app.id}/icon.png
There was a problem hiding this comment.
We are using it for Electron. (WIP, will become important going forward)
There was a problem hiding this comment.
OK so I'll leave it like this
src/DappIcon/dappIcon.js
Outdated
| case 'builtin': | ||
| case 'network': | ||
| default: | ||
| imageSrc = app.image; // TODO: should be `${UI_URL}${app.image}` where UI_URL=http://localhost:8180 |
There was a problem hiding this comment.
I see parity_dappsUrl and parity_wsUrl, but no parity_uiUrl. I left it like this (app.image is something like /api/content/{hash}/icon.png), and it works fine. But the ideal scenario would be to use UI_URL given by the API.
There was a problem hiding this comment.
UI url is always window.location.host.
There was a problem hiding this comment.
In a dapp, window.location.host give localhost:3001, and window.parent.location.host is inaccessible
