This repository has been archived by the owner on Jan 22, 2018. It is now read-only.

Put react as peer dependency #31

Merged

jacogr merged 1 commit into master from am-react-peer

Dec 20, 2017

Contributor

amaury1093 commented Dec 20, 2017

The dappIcons were (again) not showing in the dapp-dapp-methods, same issue of observer component not updating. I think it's because I use prop-types in js-ui, but found out it wasn't in package.json (same pb last time with @parity/mobx).
Since I added prop-types, I decided to put it, as well as react, as a peer dependency. Makes more sense (FWIW yarn recommends it).


          Put react as peer dependency

569f27a

amaury1093 added the A0-pleasereview label

jacogr merged commit d6b111c into master

jacogr added A8-looksgood and removed A0-pleasereview labels

jacogr deleted the am-react-peer branch

December 20, 2017 10:36

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels