archive: Use subscriptions for storageDiff
#161
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
|
|
||
| Where `subscription` is the value returned by this function, and `result` can be one of: | ||
|
|
||
| ### storageDiff |
There was a problem hiding this comment.
Perhaps just remove this line, since this object is no longer returned by this function?
There was a problem hiding this comment.
I've removed the The JSON object returned by this function has the following format. Dq: is that the line mentioned? 🤔
There was a problem hiding this comment.
LGTM, just a small wording tweak suggestion.
I would still like to see whether @tomaka has any further thoughts, but my general feeling is that this change is worth doing.
I also wonder how consistent this should be with archive_storage. That call contains a paginationStartKey param which I don't fully understand (given it appears to return everything at once). Should it also be a subscription so that it's able to stream the possibly large set of values found from a users request (again, rather than building up such a set in memory and then sending the whole thing)?
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
This PR modifies the
archive_unstable_storageDiffas a subscription instead of a method.The change mainly leverages subscriptions' backpressure without implementing a low-level API by the RPC crates.
This is a followup from:
cc @paritytech/subxt-team