Add client transport features #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
approved these changes
May 30, 2019
Like in general or just in this project? Seems like a footgun worth knowing about! |
dvdplm
approved these changes
May 30, 2019
I think in general, the point of workspace is just to group a bunch of related projects, but a workspace crate can't really be imported or used as a library. |
Reduces number of builds
|
Will this fix CI you reckon? |
|
Cleared the caches and reran - seemed to do the trick |
dvdplm
added a commit
that referenced
this pull request
May 30, 2019
* master: Add client transport features (#439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #431.
I've changed the CI script to run
core-clientbuild for the new features with--manifest-path=core-client/Cargo.tomlsince the features don't work with the top level cargo workspace.