hosts: when binding to unspecified address allow requests from localhost #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting address to unspecified usually means that we're interested to listen on all interfaces so IMO it makes sense that we won't be filtering requests from localhost.
Found this while debugging substrate since when running with
--unsafe-rpc-externalwe will bind to0.0.0.0(which is opaque to the user) and will enable host filtering. It was surprising to me that requests to localhost or127.0.0.1wouldn't work. If you prefer I can instead make sure that substrate always addlocalhostand127.0.0.1as allowed hosts but imo this is a nice default to have here.