Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for other headers besides Origin in the ws client #531

Closed
Tracked by #492
except opened this issue Oct 16, 2021 · 3 comments
Closed
Tracked by #492

Support for other headers besides Origin in the ws client #531

except opened this issue Oct 16, 2021 · 3 comments

Comments

@except
Copy link

except commented Oct 16, 2021

I would like to use this crate however a certain API requires a user to send an Authorization header before upgrading, will there be support for extra headers?
@except except changed the title Support for other headers besides Origin Support for other headers besides Origin in the ws client Oct 16, 2021
@niklasad1
Copy link
Member

niklasad1 commented Oct 18, 2021 •
edited
Loading

Hey,

I don't quite follow but it sounds like you want the ws-client to support sending custom headers during the HTTP handshake, is that correct?

I think it sounds reasonable to support custom headers, should be quite easy to fix.

@except
Copy link
Author

except commented Oct 18, 2021

Yep that is what I was looking for

@dvdplm dvdplm mentioned this issue Oct 19, 2021
Closed
10 tasks
niklasad1 added a commit that referenced this issue Oct 19, 2021
@niklasad1
feat(ws client): support custom headers.
d973e96 
Closing #531
@niklasad1 niklasad1 mentioned this issue Oct 19, 2021
Merged
dvdplm added a commit that referenced this issue Oct 21, 2021
@niklasad1 @dvdplm
feat(ws client): support custom headers. (#535)
926f891 
* feat(ws client): support custom headers.

Closing #531

* remove empty line

* address grumbles: more user-friendly API

* Update ws-client/src/client.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update ws-client/src/client.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update ws-client/src/client.rs

Co-authored-by: David <dvdplm@gmail.com>

* address grumbles

Co-authored-by: David <dvdplm@gmail.com>
@dvdplm
Copy link
Contributor

dvdplm commented Oct 21, 2021

Closed via #535

@dvdplm dvdplm closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dvdplm @niklasad1 @except