Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove batch response #1020

Merged
merged 5 commits into from
Feb 18, 2023
Merged

remove batch response #1020

merged 5 commits into from
Feb 18, 2023

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Feb 16, 2023

closes #1019

@xlc xlc requested a review from a team as a code owner February 16, 2023 08:01
niklasad1
niklasad1 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xlc and others added 3 commits February 17, 2023 10:29
@xlc
Copy link
Contributor Author

xlc commented Feb 17, 2023

@niklasad1 good to merge this?

@niklasad1
Copy link
Member

it just needs another review

@niklasad1 niklasad1 merged commit 42e640c into paritytech:master Feb 18, 2023
@xlc xlc deleted the remove-batch-response branch February 18, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is the point of BatchResponse?
3 participants
@xlc @niklasad1 @lexnv