feat: get connection id from PendingSubscriptionSink #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds public associated method to PendingSubscriptionSink, which allows for retrieval of connection identifier, which was used to perform subscription request
niklasad1
approved these changes
Aug 2, 2023
jsdw
approved these changes
Aug 2, 2023
|
yeah, we should probably the same to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds public associated method to PendingSubscriptionSink, which allows for retrieval of connection identifier, which was used to perform subscription request
motivation: sometimes it's useful to have a link between websocket subscription and websocket connection, e.g. for preventing duplicate subscriptions on the same connection. Currently there's no API exposing underlying connection identifier, so this PR adds a public method just for this purpose.