Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: remove beef #1401

Merged
merged 1 commit into from
Jun 14, 2024
Merged

deps: remove beef #1401

merged 1 commit into from
Jun 14, 2024

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Jun 11, 2024 •
edited
Loading

Since 1.76, Cow<str> is 3 words wide (see rust-lang/rust#117763), and the lean::Cow type is not used, thus making the beef dependency obsolete.

This is a breaking change as it's exposed in Id, SubscriptionId, and jsonrpsee::core::Cow, and the beef::Cow and std::borrow::Cow APIs are slightly different.

@DaniPopes DaniPopes requested a review from a team as a code owner June 11, 2024 03:14
@niklasad1 niklasad1 added the breaking change Breaking change in the public APIs label Jun 11, 2024
niklasad1
niklasad1 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, news to me thanks for the info.

Nice, to make the dependency tree smaller

jsdw
jsdw approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, always happy to simplify a bit :)

@niklasad1 niklasad1 merged commit cdb931d into paritytech:master Jun 14, 2024
10 checks passed
@DaniPopes DaniPopes deleted the remove-beef branch June 14, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
breaking change Breaking change in the public APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaniPopes @jsdw @niklasad1 @lexnv