Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http client: add max_concurrent_requests #1473

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Oct 9, 2024

I decided to add back max_concurrent_requests to provide a uniform API because the ws-client already provides it.
This is only opt-in because it may be annoying with the extra sempahore overhead which some use-cases may not want..

Superseeds #1470

@niklasad1 niklasad1 requested a review from a team as a code owner October 9, 2024 13:37
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd generally lean towards saying "if this can be implemented outside of the library then it should be" but for the sake of consistency I don't mind it :)

@niklasad1
Copy link
Member Author

I'd generally lean towards saying "if this can be implemented outside of the library then it should be" but for the sake of consistency I don't mind it :)

Yes, that was the intention by removing it but I prefer to keep the APIs somewhat consistent instead after thinking about it

@niklasad1 niklasad1 requested a review from lexnv October 14, 2024 13:44
@niklasad1 niklasad1 merged commit fa5b1ce into master Oct 16, 2024
11 checks passed
@niklasad1 niklasad1 deleted the na-http-client-max-concurrent-calls branch October 16, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants