Sort out type paths in proc macros #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
changed the title
jsonrpsee as well
jsdw
reviewed
Jul 12, 2021
There was a problem hiding this comment.
Offhand (though github is being slow for me), it looks like CI caught the problem with the last PR? If that's the case then this looks good given that CI has passed, but I haven't locally tested the various path changes (they all look minor and like things that should be caught though).
maciejhirsz
approved these changes
Jul 12, 2021
Yup, I did all the wrong things there, all of them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed one place where "types" was added to the crate name instead of when the types are actually used. Only pops up when the crate name searched for is "jsonrpsee".
Should un-break the
proc_macroexample, which I tried to unbreak in #413 after breaking them in #409.