Add a setter for middleware #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejhirsz
reviewed
Nov 24, 2021
examples/middleware.rs
Outdated
| impl middleware::Middleware for ManInTheMiddle { | ||
| type Instant = u64; | ||
| fn on_request(&self) -> Self::Instant { | ||
| self.when + 1 |
There was a problem hiding this comment.
Suggested change
| self.when + 1 | |
| self.when += 1; | |
| self.when |
maciejhirsz
suggested changes
Nov 24, 2021
| @@ -56,7 +56,7 @@ const MAX_CONNECTIONS: u64 = 100; | |||
|
|
|||
| /// A WebSocket JSON RPC server. | |||
| #[derive(Debug)] | |||
| pub struct Server<M = ()> { | |||
| pub struct Server<M> { | |||
There was a problem hiding this comment.
Why remove the default?
There was a problem hiding this comment.
Was trying to make Builder::default() work and this seemed to be in the way, but I don't think this was the problem. OTOH: do we need it?
There was a problem hiding this comment.
I'd keep it, all it does is if you don't use middleware you can just write WsServer instead of WsServer<()>.
maciejhirsz
reviewed
Nov 24, 2021
maciejhirsz
reviewed
Nov 24, 2021
Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com>
Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com>
maciejhirsz
approved these changes
Nov 24, 2021
Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com>
dvdplm
added a commit
that referenced
this pull request
Dec 1, 2021
* Squashed MethodSink * Middleware WIP * Passing all the information through * Unnecessary `false` * Apply suggestions from code review Co-authored-by: David <dvdplm@gmail.com> * Add a setter for middleware (#577) * Fix try-build tests * Add a middleware setter and an example * Actually add the example * Grumbles * Use an atomic * Set middleware with a constructor instead * Resolve a todo * Update ws-server/src/server.rs Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com> * Update ws-server/src/server.rs Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com> * Update ws-server/src/server.rs Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com> Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com> * Middleware::on_response for batches * Middleware in HTTP * fmt * Server builder for HTTP * Use actual time in the example * HTTP example * Middleware to capture method not found calls * An example of adding multiple middlewares. (#581) * Add an example of adding multiple middlewares. * Update examples/multi-middleware.rs Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com> * Update examples/Cargo.toml Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com> Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com> * Move `Middleware` to jsonrpsee-types (#582) * Move `Middleware` to jsonrpsee-types * Move Middleware trait to jsonrpsee-types * Add some docs. * Link middleware to `with_middleware` methods in docs * Doctests * Doc comment fixed * Clean up a TODO * Switch back to `set_middleware` * fmt * Tests * Add `on_connect` and `on_disconnect` * Add note to future selves Co-authored-by: David <dvdplm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and an example.
Came about as way to review #576