Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rpc error: support escaped strings #578

Merged
merged 2 commits into from
Nov 25, 2021
Merged

fix rpc error: support escaped strings #578

merged 2 commits into from
Nov 25, 2021

Conversation

niklasad1
Copy link
Member

No description provided.

@niklasad1 niklasad1 requested a review from a team as a code owner November 25, 2021 17:19
@jsdw
Copy link
Collaborator

jsdw commented Nov 25, 2021 •
edited
Loading

Ooooh, I see! owned strings needed for when you can't just resuse the message straight from the buffer, got it!

dvdplm
dvdplm approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@niklasad1 @maciejhirsz
Update types/src/v2/error.rs
d821bb4 
Co-authored-by: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com>
@niklasad1 niklasad1 merged commit d4e53f8 into master Nov 25, 2021
@niklasad1 niklasad1 deleted the na-rpc-error-support-unquoted-str branch November 25, 2021 19:15
@niklasad1 niklasad1 changed the title fix rpc error: support unquoted strings fix rpc error: support escaped strings Nov 25, 2021
@ascjones ascjones mentioned this pull request Nov 26, 2021
Merged
@niklasad1 niklasad1 mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@insipx insipx insipx approved these changes

@jsdw jsdw jsdw approved these changes

@maciejhirsz maciejhirsz maciejhirsz approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@niklasad1 @jsdw @dvdplm @maciejhirsz @insipx @TarikGul