Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benches: make jsonrpc crates optional #596

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

niklasad1
Copy link
Member

Make the dependency tree smaller with the default bench dependencies.

@niklasad1 niklasad1 requested a review from a team as a code owner December 8, 2021 18:22
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this require a change to CI too, so we run the jsonrpc benches too?

@niklasad1
Copy link
Member Author

niklasad1 commented Dec 8, 2021

Doesn't this require a change to CI too, so we run the jsonrpc benches too?

We're not running the daily benches on jsonrpc crate (hidden behind the feature flag jsonrpc-crate), why should we?
Isn't sufficient to run against it on releases?

However, it would probably be good to automate it otherwise it's easy to forget... so maybe not a bad idea do run it daily/weekly or something.

@niklasad1 niklasad1 merged commit d3b4706 into master Dec 9, 2021
@niklasad1 niklasad1 deleted the feature-gate-jsonrpc-benches branch December 9, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants