Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http client): add tower middleware #981

Merged
merged 14 commits into from
Feb 1, 2023
Merged

feat(http client): add tower middleware #981

merged 14 commits into from
Feb 1, 2023

Conversation

niklasad1
Copy link
Member

No description provided.

@niklasad1 niklasad1 marked this pull request as ready for review January 30, 2023 21:02
@niklasad1 niklasad1 requested a review from a team as a code owner January 30, 2023 21:02
lexnv
lexnv reviewed Jan 31, 2023
View reviewed changes
core/src/http_helpers.rs Outdated Show resolved Hide resolved
lexnv
lexnv approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing job 👍

lexnv
lexnv reviewed Jan 31, 2023
View reviewed changes
core/src/http_helpers.rs Outdated Show resolved Hide resolved
jsdw
jsdw reviewed Jan 31, 2023
View reviewed changes
examples/examples/http.rs
.on_response(DefaultOnResponse::new().include_headers(true).latency_unit(LatencyUnit::Micros)),
);

let client = HttpClientBuilder::default().set_middleware(middleware).build(url)?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

jsdw
jsdw approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of small things :)

niklasad1
niklasad1 commented Feb 1, 2023
View reviewed changes
core/src/http_helpers.rs Outdated Show resolved Hide resolved
@niklasad1 niklasad1 merged commit 0fbca18 into master Feb 1, 2023
@niklasad1 niklasad1 deleted the na-client-tower-middleware branch February 1, 2023 16:56
@niklasad1 niklasad1 mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @jsdw @lexnv