Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: use tokio channels #999

Merged
merged 10 commits into from
Jan 31, 2023
Merged

client: use tokio channels #999

merged 10 commits into from
Jan 31, 2023

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Jan 31, 2023

This PR replaces the future channels with tokio because the APIs fit our use-cases better.

In addition #962 will migrate to tokio channels as well.

This PR replaces the future channels with tokio because the APIs fit our use-cases better.
@niklasad1 niklasad1 requested a review from a team as a code owner January 31, 2023 13:09
core/src/client/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM offhand; just one unwrap that I wasn't sure on!

@niklasad1 niklasad1 merged commit 1a2a199 into master Jan 31, 2023
@niklasad1 niklasad1 deleted the na-client-tokio-channels branch January 31, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants