fix bincode deserialization #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement and use a new PublicKeyBytesVisitor for deserializing bytes to a PublicKey * add a test to cover bincode serialization / deserialization * return the base64 decoding error instead of unwrapping
sorpaas
approved these changes
Apr 8, 2022
|
Hey @sorpaas, when will we see this deployed to crates? |
trevor-crypto
pushed a commit
to monacohq/libsecp256k1
that referenced
this pull request
May 31, 2022
* implement and use a new PublicKeyBytesVisitor for deserializing bytes to a PublicKey * add a test to cover bincode serialization / deserialization * return the base64 decoding error instead of unwrapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the current bincode de/serialization has a bug:
PublicKey::serializemethod.PublicKeyinstead of calling the correspondingPublicKey::parse_slicefunction.Additionally, bincode serialization isn't covered in the tests.
Therefore, this PR does the following: