Make static-context and lazy-static-context addictive #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hate to be this guy but we need a |
dvdplm
approved these changes
Sep 15, 2021
Comment on lines
50
to
51
| /// A static ECMult context. | ||
| // Correct `pre_g` values are fed into `ECMultContext::new_from_raw`, generated by build script. |
There was a problem hiding this comment.
Suggested change
| /// A static ECMult context. | |
| // Correct `pre_g` values are fed into `ECMultContext::new_from_raw`, generated by build script. | |
| /// A static ECMult context. Requires that the `static-context` to be enabled and that `lazy-static-context` is **not** enabled. | |
| /// Correct `pre_g` values are fed into `ECMultContext::new_from_raw`, generated by build script. |
There was a problem hiding this comment.
ECMULT_CONTEXT is defined either here or through lazy_static. It is always available either with static-context or lazy-static-context.
The second line is related to implementation details of how this is generated, so it doesn't really fit the docs.
| /// A static ECMult context. | ||
| // Correct `pre_g` values are fed into `ECMultContext::new_from_raw`, generated by build script. | ||
| pub static ECMULT_CONTEXT: ECMultContext = | ||
| unsafe { ECMultContext::new_from_raw(include!(concat!(env!("OUT_DIR"), "/const.rs"))) }; | ||
|
|
||
| #[cfg(feature = "static-context")] | ||
| #[cfg(all(feature = "static-context", not(feature = "lazy-static-context")))] | ||
| /// A static ECMultGen context. |
There was a problem hiding this comment.
Same note in the docs here.
athei
approved these changes
Sep 16, 2021
trevor-crypto
pushed a commit
to monacohq/libsecp256k1
that referenced
this pull request
May 31, 2022
* Make static-context and lazy-static-context addictive * Fix README docs regarding `lazy-static-context` overwrites `static-context`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #77