-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/dotgraph: implement dot graph rendering as part of the proc-macro #43
Conversation
For |
5de613d
to
aca7e21
Compare
dd0045f
to
6f5f478
Compare
Do we really need a png output counting that the conversion svg->png is a trivial thing? |
Up for debate, happy to delete it |
@vstakhov removed the png generation, (another) review would be much appreciated |
7109a1b
to
41682d3
Compare
Rebased the branch |
Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
PNGs generated lack text, and hence are broken until the upstream crates resolve the issue. Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
41682d3
to
483a19d
Compare
The generated files are far from perfect,layout-rs
is not working out too well..The generated files only deviate in the sense that double circles are not rendered accurately, otherwise the output looks fine.
The
png
rendered lacks text render capabilities, and is hence feature gated for now.