Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/dotgraph: implement dot graph rendering as part of the proc-macro #43

Merged
merged 8 commits into from
Jul 18, 2023

Conversation

drahnr
Copy link
Collaborator

@drahnr drahnr commented Apr 13, 2023

The generated files are far from perfect, layout-rs is not working out too well..

The generated files only deviate in the sense that double circles are not rendered accurately, otherwise the output looks fine.

The png rendered lacks text render capabilities, and is hence feature gated for now.

@sandreim
Copy link
Collaborator

For Polkadot the output of the graph is quite hard to reason about, so one improvement I was thinking about is to add some parameter such that only selected subsystems are present in the graph. WDYT ?

@drahnr drahnr force-pushed the bernhard-use-rust-crates-for-dot-rendering branch from 5de613d to aca7e21 Compare July 5, 2023 09:58
@drahnr drahnr marked this pull request as ready for review July 5, 2023 09:58
@drahnr drahnr requested review from sandreim and vstakhov July 5, 2023 11:06
@drahnr drahnr force-pushed the bernhard-use-rust-crates-for-dot-rendering branch 3 times, most recently from dd0045f to 6f5f478 Compare July 5, 2023 11:19
@drahnr
Copy link
Collaborator Author

drahnr commented Jul 9, 2023

@vstakhov @sandreim if you could give it a glance :)

There are trade-offs:

➕ self sufficient svg generation / independence of the environment
➖ slightly increased build time due to additional dependencies

@vstakhov
Copy link
Contributor

Do we really need a png output counting that the conversion svg->png is a trivial thing?

@drahnr
Copy link
Collaborator Author

drahnr commented Jul 10, 2023

Do we really need a png output counting that the conversion svg->png is a trivial thing?

Up for debate, happy to delete it

@drahnr
Copy link
Collaborator Author

drahnr commented Jul 12, 2023

@vstakhov removed the png generation, (another) review would be much appreciated

@vstakhov vstakhov force-pushed the bernhard-use-rust-crates-for-dot-rendering branch from 7109a1b to 41682d3 Compare July 18, 2023 14:01
@vstakhov
Copy link
Contributor

Rebased the branch

drahnr added 8 commits July 18, 2023 17:01
Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
PNGs generated lack text, and hence are broken until the upstream crates
resolve the issue.

Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
Signed-off-by: Bernhard Schuster <bernhard@ahoi.io>
@drahnr drahnr force-pushed the bernhard-use-rust-crates-for-dot-rendering branch from 41682d3 to 483a19d Compare July 18, 2023 15:03
@drahnr drahnr merged commit 483a19d into master Jul 18, 2023
@drahnr drahnr deleted the bernhard-use-rust-crates-for-dot-rendering branch July 18, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants