Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try_send method to the orchestra output channels #46

Merged
merged 8 commits into from
May 22, 2023
Merged

Add try_send method to the orchestra output channels #46

merged 8 commits into from
May 22, 2023

Conversation

vstakhov
Copy link
Contributor

@vstakhov vstakhov commented May 11, 2023 •
edited
Loading

This PR addresses #44. WIP currently:

  • Initial implementation of the try_send in channels
  • Think more about error type
  • Add tests

drahnr
drahnr reviewed May 12, 2023
View reviewed changes
orchestra/src/lib.rs Outdated Show resolved Hide resolved
drahnr
drahnr approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vstakhov vstakhov marked this pull request as ready for review May 17, 2023 20:01
sandreim
sandreim approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 1 fix needed.

metered-channel/src/bounded.rs Outdated Show resolved Hide resolved
@vstakhov vstakhov requested review from drahnr and sandreim May 18, 2023 14:55
@vstakhov vstakhov merged commit d8a83f3 into master May 22, 2023
@drahnr drahnr deleted the vstakhov-try-send branch May 22, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreim sandreim sandreim approved these changes

@drahnr drahnr drahnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstakhov @drahnr @sandreim