Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add convenience conversion for TrySend error #53

Merged
merged 1 commit into from
Jul 21, 2023
Merged

feat: add convenience conversion for TrySend error #53

merged 1 commit into from
Jul 21, 2023

Conversation

drahnr
Copy link
Collaborator

@drahnr drahnr commented Jul 21, 2023 •
edited
Loading

#48 introduced aliasing error types, but didn't provide publicly acessible From<_> implementations. This PR adds those and makes use of them internally.

@drahnr drahnr requested review from sandreim and vstakhov and removed request for sandreim July 21, 2023 13:10
sandreim
sandreim approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I don't think async_channel should be a default feature.

@drahnr drahnr merged commit ebb178f into master Jul 21, 2023
@drahnr drahnr deleted the bernhard-gammarays branch July 21, 2023 14:06
@drahnr drahnr mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreim sandreim sandreim approved these changes

@vstakhov vstakhov vstakhov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drahnr @vstakhov @sandreim