Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple events of same type #73

Merged
merged 7 commits into from
Dec 26, 2022

Conversation

evilrobot-01
Copy link
Contributor

  • adds support for multiple events of same type, using existing logic to evaluate potential match (based on event config) before allocation to event result
    • isolates change to a single function
    • cloning could be heavy, but simplest way to evaluate match before accepting
  • added simple test to ensure functionality works as expected, useful for regression testing. e.g. yarn zombienet-test -t tests -c tests/config.toml
  • enabled sourcemap generation within tsconfig.json for debugging (not sure of any side-effects)

Note: unable to check examples due to missing binaries (collectives-polkadot) and statemin(e/t) not producing blocks, possibly due to me using polkadot/polkadot-parachain built on 0.9.30. The collators dont seem to be peering, which was an issue with my firewall in the past.

@evilrobot-01 evilrobot-01 linked an issue Oct 28, 2022 that may be closed by this pull request
@evilrobot-01 evilrobot-01 requested a review from NachoPal October 29, 2022 07:31
@evilrobot-01 evilrobot-01 marked this pull request as draft October 29, 2022 09:08
@evilrobot-01 evilrobot-01 force-pushed the frank/feat-multiple-events-of-type branch from 8dea2aa to 3b8f781 Compare October 29, 2022 10:38
@evilrobot-01 evilrobot-01 marked this pull request as ready for review October 29, 2022 10:45
@evilrobot-01
Copy link
Contributor Author

Note: I have noticed that tests time out if no expected matching event is found, but havent yet verified whether this was the case prior to this PR (e.g. a misspelling in expected event name). Will convert to draft until I have confirmed.

@evilrobot-01 evilrobot-01 marked this pull request as draft November 10, 2022 13:18
@evilrobot-01 evilrobot-01 linked an issue Nov 11, 2022 that may be closed by this pull request
@evilrobot-01
Copy link
Contributor Author

Confirmed that the latest release does indeed suffer the same issue: a timeout occurs if an expected event is not matched (e.g. misspelled name):

Error: Timeout of 300000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/user/.config/yarn/global/node_modules/@parity/parachains-integration-tests/dist/run.js)

@NachoPal NachoPal marked this pull request as ready for review December 5, 2022 08:47
@NachoPal NachoPal merged commit 41223d6 into master Dec 26, 2022
NachoPal added a commit that referenced this pull request Feb 2, 2024
…type

Support multiple events of same type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to differentiate two events of one type
2 participants