Rpc block template #270
Merged
Rpc block template #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
commented
Dec 9, 2016
| mode: None, | ||
| capabilities: None, | ||
| rules: None, | ||
| }).unwrap(), r#"{"mode":null,"capabilities":null,"rules":null}"#); |
There was a problem hiding this comment.
Is there a standard way to not to serialize field at all if its value is None?
There was a problem hiding this comment.
I expected that serialized value would be just {}
svyatonik
commented
Dec 9, 2016
| /// Difference in value between transaction inputs and outputs (in Satoshis). | ||
| /// For coinbase transactions, this is a negative Number of the total collected block fees (ie, not including the block subsidy). | ||
| /// If key is not present, fee is unknown and clients MUST NOT assume there isn't one | ||
| pub fee: Option<Option<i64>>, |
There was a problem hiding this comment.
Option<Option<>> - will fix this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #267
this commit only: 88b4f1a
just to discuss RPC BlockTemplate struct fields - are these enough? or am I missed some? maybe wrong types? there are too many info on this structure - I've got most of structure from here:
https://github.com/bitcoin/bitcoin/blob/master/src/rpc/mining.cpp#L346