Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or remove XcmRouterWeigher from the bridge-runtime-common crate #1986

Closed
svyatonik opened this issue Mar 23, 2023 · 1 comment · Fixed by #1990
Closed

Fix or remove XcmRouterWeigher from the bridge-runtime-common crate #1986

svyatonik opened this issue Mar 23, 2023 · 1 comment · Fixed by #1990
Labels
P-Runtime
Milestone
Rococo<>Wococo Pa...

Comments

@svyatonik
Copy link
Contributor

Original comment: https://github.com/paritytech/parity-bridges-common/pull/1983/files#r1144296320
So right now we have this XcmRouterWeigher in the bridge-runtime-common, which is a copy of what @bkontur did with RBH and WBH. For Rialto/Millau/RialtoParachain, it is fine, but for RBH/WBH (and especially for KBH/PBH) it requires some fixes (see comment for details).

cc @bkontur
@svyatonik svyatonik mentioned this issue Mar 23, 2023
Merged
@svyatonik
Copy link
Contributor Author

I'm currently exploring the benchmark-message-dispatch-weight option. Will come back with results

@svyatonik svyatonik mentioned this issue Mar 24, 2023
Merged
Closed
34 tasks
svyatonik pushed a commit that referenced this issue Jul 17, 2023
@alvicsam
[ci] Add variable to disable selected jobs (#1986)
3d13ae0 
* [ci] Add variable to disable selected jobs

* apply suggestion

Co-authored-by: parity-processbot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-Runtime
Projects
None yet
Milestone
Rococo<>Wococo Parachain Bridge Release
Development

Successfully merging a pull request may close this issue.

Added receive_single_message_proof_with_dispatch benchmark paritytech/parity-bridges-common
1 participant
@svyatonik