Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weight of our signed extensions to the messages pallet calls #2024

Closed
Tracked by #2430
svyatonik opened this issue Apr 6, 2023 · 0 comments · Fixed by #2089
Closed
Tracked by #2430

Add weight of our signed extensions to the messages pallet calls #2024

svyatonik opened this issue Apr 6, 2023 · 0 comments · Fixed by #2089

Comments

@svyatonik
Copy link
Contributor

So bridge hub will have our signed extensions that reject obsolete transactions and pay reward/slash relayers. The obsolete-check reads the same storage entries as the call itself does, so we assume it brings no additional weight (it does, but not that much). However, the post_dispatch may add/update entries of the pallet-bridge-relayers rewards map. So we should add this weight to our call weights (delivery and confirmation). Maybe something as simple as DbWeight.reads_writes(1, 1).set_proof_size(<proof-size-that-we-may-get-from-relayers-pallet-benchmarks>). But maybe some benchmark is ok too.

svyatonik pushed a commit that referenced this issue Jul 17, 2023
Bumps [async-trait](https://github.com/dtolnay/async-trait) from 0.1.59 to 0.1.60.
- [Release notes](https://github.com/dtolnay/async-trait/releases)
- [Commits](dtolnay/async-trait@0.1.59...0.1.60)

---
updated-dependencies:
- dependency-name: async-trait
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant