Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore nonstandard_macro_braces clippy warning #1054

Closed
wants to merge 5 commits into from
Closed

Conversation

svyatonik
Copy link
Contributor

No description provided.

@svyatonik svyatonik added the A-chores Something that has to be done, as part of regular maintenance label Jul 15, 2021
@svyatonik
Copy link
Contributor Author

Related issue: rust-lang/rust-clippy#7434
And re that ICE: rust-lang/rust-clippy#7423 - should hopefully be fixed in tomorrow nightly

@svyatonik
Copy link
Contributor Author

(this PR is a bit too late - everything is fixed in nightly as of today)

@svyatonik svyatonik closed this Jul 19, 2021
@tomusdrw tomusdrw deleted the ignore-clippy branch November 15, 2021 14:49
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
* polkadot-collator: Switch to wasm only

This switches the polkadot-collator to run everything in wasm only mode. While we should not that
yet with the relay chain, because it can happen that we run out of memory (very unlikely). On the
relay chain that would be bad, because we only have at max 2 sessions to bring everything back, for
Parachains that isn't such a problem as they would only stall and we could roll out a release that
fixes it. Besides that, Parachain validation on the relay chain happens in Wasm already all the time
and there is the memory usage even higher then on block import.

* cargo fmt

* remove unused var

Co-authored-by: Squirrel <gilescope@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chores Something that has to be done, as part of regular maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants