Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused deps #1102

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Conversation

gilescope
Copy link
Contributor

Some deps that did not appear to be used any longer.

Please shout out if you want to keep them!

@gilescope gilescope added A-chores Something that has to be done, as part of regular maintenance dependencies Pull requests that update a dependency file labels Sep 1, 2021
@svyatonik
Copy link
Contributor

I don't think we need unused deps! :) Can you, please, merge master, to avoid CI errors? Thanks!

Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if the CI is happy :)

fuzz/storage-proof/README.md Show resolved Hide resolved
@svyatonik
Copy link
Contributor

Could you, please, just merge master instead of last two commits? :) Missing docs are already there plus it'll solve conflicts :) Thanks!

@gilescope
Copy link
Contributor Author

sorry - will do.

@gilescope gilescope force-pushed the giles-remove-unused-deps branch from 5d0f3ba to 39d014d Compare September 1, 2021 11:49
@gilescope
Copy link
Contributor Author

(I wouldn't normally force push but in this case it seemed the right call).

@gilescope
Copy link
Contributor Author

btw clippy ICEs on my machine when I run it against this repo. Have raise it to them.

@svyatonik
Copy link
Contributor

btw clippy ICEs on my machine when I run it against this repo. Have raise it to them.

Could be rust-lang/rust-clippy#7423 - I've had this a while ago. Now (did a rustup update yesterday) everything is fine.

Thanks!

@svyatonik svyatonik merged commit a517e85 into paritytech:master Sep 1, 2021
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
* Register dev api for canvas parachain

* Update Substrate

* Update Polkadot
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
* remove unused dev deps

* Removing unused deps
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
* remove unused dev deps

* Removing unused deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chores Something that has to be done, as part of regular maintenance dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants