Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings + try to enable proper (no-warning) clippy on CI #1410

Merged
merged 5 commits into from
May 25, 2022
Merged

Fix clippy warnings + try to enable proper (no-warning) clippy on CI #1410

merged 5 commits into from
May 25, 2022

Conversation

svyatonik
Copy link
Contributor

No description provided.

@svyatonik svyatonik added the A-chores Something that has to be done, as part of regular maintenance label May 25, 2022
@svyatonik svyatonik requested a review from a team as a code owner May 25, 2022 07:11
acatangiu
acatangiu approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svyatonik svyatonik merged commit ba8d953 into master May 25, 2022
@svyatonik svyatonik deleted the fix-clippy branch May 25, 2022 09:57
wuminzhe added a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Aug 8, 2022
@wuminzhe
Companion for 1410
12e1484 
paritytech/parity-bridges-common#1410
@wuminzhe wuminzhe mentioned this pull request Aug 9, 2022
Closed
30 tasks
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
@koushiro
Use genesis_state_version param instead of StateVersion::V0 (#1410)
3175d2f 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
@svyatonik
Fix clippy warnings + try to enable proper (no-warning) clippy on CI (p…
056f619 
…aritytech#1410)

* fix clippy warnings

* try to reenable proper clippy on CI

* fix clippy error

* more Eqs

* ignore clippy::derive-partial-eq-without-eq - clippy seems to be broken now :/
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
@svyatonik
Fix clippy warnings + try to enable proper (no-warning) clippy on CI (p…
7e2994b 
…aritytech#1410)

* fix clippy warnings

* try to reenable proper clippy on CI

* fix clippy error

* more Eqs

* ignore clippy::derive-partial-eq-without-eq - clippy seems to be broken now :/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
A-chores Something that has to be done, as part of regular maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svyatonik @acatangiu