Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate owner calls for some pallets #1477

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Deduplicate owner calls for some pallets #1477

merged 1 commit into from
Jun 27, 2022

Conversation

serban300
Copy link
Collaborator

Some simplifications that should make it easier to implement #1434

Avoid duplicate function definitions for:

  • ensure_owner_or_root()
  • ensure_not_halted()
  • set_owner()
  • set_operating_mode() / set_operational()

@serban300 serban300 self-assigned this Jun 27, 2022
@serban300 serban300 force-pushed the parachains_operating_mode_and_owner branch from 1ec48e4 to 034e100 Compare June 27, 2022 09:36
svyatonik
svyatonik approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems super-cool, thank you! I've left some comments - feel free to merge whenever you consider PR ready

primitives/runtime/Cargo.toml Outdated Show resolved Hide resolved
primitives/runtime/src/lib.rs Outdated Show resolved Hide resolved
primitives/runtime/src/lib.rs Show resolved Hide resolved
primitives/runtime/src/lib.rs Show resolved Hide resolved
modules/grandpa/src/lib.rs Outdated Show resolved Hide resolved
@serban300
Avoid duplicate function definitions
8473328 
Avoid duplicate function definitions for:
- ensure_owner_or_root()
- ensure_not_halted()
- set_owner()
- set_operating_mode() / set_operational()

Signed-off-by: Serban Iorga <serban@parity.io>
@serban300 serban300 mentioned this pull request Jun 27, 2022
Closed
@serban300 serban300 force-pushed the parachains_operating_mode_and_owner branch from 034e100 to 8473328 Compare June 27, 2022 11:54
svyatonik
svyatonik approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! Hit merge once it is green ;)

@serban300
Copy link
Collaborator Author

Seems super-cool, thank you! I've left some comments - feel free to merge whenever you consider PR ready

@svyatonik Thank you for the review ! I addressed the comments and opened a new issue for changing IsHalted to an enum. Could you check again if everything seems ok please ? Just to make sure if I can merge the PR. Thanks !

@serban300
Copy link
Collaborator Author

Perfect, thank you! Hit merge once it is green ;)

Ah awesome. Thanks !

@serban300 serban300 merged commit 0adb4f9 into paritytech:master Jun 27, 2022
@boundless-forest boundless-forest mentioned this pull request Sep 9, 2022
Closed
30 tasks
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
@alvicsam
[ci] use nextest for tests (#1477)
c5dc2e3 
* [do not merge] ci: try nextest

* uncomment jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svyatonik svyatonik svyatonik approved these changes

Assignees

@serban300 serban300

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serban300 @svyatonik