Remove callbacks from the messages pallet #1649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1647
Why we are removing callbacks: in our previous vision the messaging pallet was the central pallet, which has been used by end-users and other pallets to build their own apps (e.g. our dead token swap pallet). So callbacks were used to tie pallets together. In current version, messaging pallet is just a transport for the XCM messages, sent by other pallets. Those pallets should have their own callbacks when required + XCM has the
QueryPallet
instruction to send messages back to the sender (which can be used as a replacement for theOnMessageDelivered
callback).