Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility to generate hex bytes for send-message command #1658

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Nov 22, 2022

No description provided.

Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure what is the point of having it in the codebase? But if you think it'll be helpful - let's keep it.

@bkontur bkontur enabled auto-merge (squash) November 22, 2022 11:37
@bkontur bkontur merged commit ab30d00 into master Nov 22, 2022
@bkontur bkontur deleted the bko-hex-data branch November 22, 2022 11:37
@bkontur
Copy link
Contributor Author

bkontur commented Nov 22, 2022

I'm not quite sure what is the point of having it in the codebase? But if you think it'll be helpful - let's keep it.

well, at least, we will now how was that const 020419ac generated,
and also can be useful for anybody else to play with bridges: https://substrate.stackexchange.com/questions/5901/failed-to-run-parity-bridges-common-message-realy-demo/5906#5906

@bkontur
Copy link
Contributor Author

bkontur commented Nov 22, 2022

I'm not quite sure what is the point of having it in the codebase? But if you think it'll be helpful - let's keep it.

@svyatonik no problem, we can also remove that, is there any utility for simple generation XCM messages?

@svyatonik
Copy link
Contributor

My point is that this test isn't actually testing something :) Also it does prints, so it looks more like a good candidate to became a subcommand of substrate-relay (we already had the encode-message subcommand before). But for XCM - what you gonna pass using CLI? You'll need some other language to describe what you actually want, so imo it doesn't worth it.

As for the encoding tool, you can use https://polkadot.js.org/apps/. E.g.:
Screenshot from 2022-11-22 15-17-15

@bkontur
Copy link
Contributor Author

bkontur commented Nov 22, 2022

As for the encoding tool, you can use https://polkadot.js.org/apps/. E.g.: Screenshot from 2022-11-22 15-17-15

hmm, polkadot.js.org thats where I started yesterday, but it didnt work,
I will try that later again, and when it will work as I expect, I will remove that test

jiguantong pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Apr 19, 2023
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants