Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same fmt and clippy configs as in Polkadot/Cumulus #2352

Closed
wants to merge 37 commits into from

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Aug 15, 2023

Lets see if it works

Closes: #2383

svyatonik and others added 30 commits July 21, 2023 09:52
This reverts commit 48f1ba0.
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…2313)

* Ability to externalize configuration for `ExporterFor`
(Replaced `BridgedNetworkId/SiblingBridgeHubLocation` with `Bridges: ExporterFor`)

* Fix millau

* Compile fix

* Return back `BridgedNetworkId` but as optional filter

* Replaced `BaseFee` with fees from inner `Bridges: ExporterFor`

* typo
* Rename LocalXcmChannel to XcmChannelStatusProvider

* fmt
* report congestion status: changes at the sending chain

* OnMessagesDelivered is back

* report congestion status: changes at the bridge hub

* moer logging

* fix? benchmarks

* spelling

* tests for XcmBlobHaulerAdapter and LocalXcmQueueManager

* tests for messages pallet

* fix typo

* rustdoc

* Update modules/messages/src/lib.rs

* apply review suggestions
@bkontur bkontur requested a review from a team as a code owner August 15, 2023 11:20
@bkontur
Copy link
Contributor Author

bkontur commented Aug 15, 2023

@svyatonik Slava, where do we need to install this?

error: 'cargo-clippy' is not installed for the toolchain 'stable-x86_64-unknown-linux-gnu'

@serban300
Copy link
Collaborator

@svyatonik Slava, where do we need to install this?

error: 'cargo-clippy' is not installed for the toolchain 'stable-x86_64-unknown-linux-gnu'

Probably here: https://github.com/paritytech/scripts/blob/master/dockerfiles/bridges-ci/Dockerfile

@bkontur
Copy link
Contributor Author

bkontur commented Aug 15, 2023

paritytech/scripts#591

Base automatically changed from bko-dynamic-fees-v1 to dynamic-fees-v1 August 16, 2023 13:28
Base automatically changed from dynamic-fees-v1 to polkadot-staging August 16, 2023 13:49
Copy link
Collaborator

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rebase and try it

@bkontur
Copy link
Contributor Author

bkontur commented Dec 20, 2023

Closing in favor of #2746

@bkontur bkontur closed this Dec 20, 2023
@bkontur bkontur deleted the align-fmt-clippy branch December 20, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants