[fixed-hash]: fix build with default-features
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloc is required by the `rustc-hex` implementation which make the `std` build to fail. This commit re-exports `alloc` for both std and no-std to fix this problem
niklasad1
commented
Nov 20, 2019
| @@ -10,7 +10,6 @@ | |||
|
|
|||
| // Re-export liballoc using an alias so that the macros can work without | |||
| // requiring `extern crate alloc` downstream. | |||
| #[cfg(not(feature = "std"))] | |||
There was a problem hiding this comment.
could also be #[cfg(any(no_std, feature = "rustc-hex"))] but std is using rustc-hex so I re-exported alloc for all instead,
niklasad1
changed the title
alloc_std build again
which command fails exactly? |
[dependencies]
fixed-hash = { path = "../parity-common/fixed-hash" }error[E0433]: failed to resolve: could not find `alloc_` in `$crate`
--> src/main.rs:3:1
|
3 | / construct_fixed_hash! {
4 | | /// My 256 bit hash type.
5 | | struct H256(32);
6 | | }
| |_^ could not find `alloc_` in `$crate`As you can see here, |
niklasad1
changed the title
std build againdefault-features
dvdplm
approved these changes
Nov 26, 2019
ordian
added a commit
that referenced
this pull request
Nov 27, 2019
dvdplm
added a commit
that referenced
this pull request
Nov 28, 2019
…h/parity-common into ao-rocksdb-switch-to-upstream2 * 'ao-rocksdb-switch-to-upstream2' of github.com:paritytech/parity-common: kvdb-rocksdb: remove lz4 feature as it has no effect for now travis: try to fix wasmpack chrome test on macOS (#263) kvdb-rocksdb: please the CI kvdb-rocksdb: do not account for default column memory budget Use 2018 edition for rustfmt (#266) [fixed-hash]: re-export `alloc_` (#268) kvdb-web: async-awaitify (#259)
dvdplm
added a commit
that referenced
this pull request
Dec 10, 2019
* master: Compile triehash for no_std (#280) [kvdb-rocksdb] Use "pinned" gets to avoid allocations (#274) [kvdb-rocksdb] Release 0.2 (#273) [kvdb-rocksdb] switch to upstream (#257) travis: try to fix wasmpack chrome test on macOS (#263) Use 2018 edition for rustfmt (#266) [fixed-hash]: re-export `alloc_` (#268) kvdb-web: async-awaitify (#259) kvdb-rocksdb: configurable memory budget per column (#256) Bump rlp crate version. (#270) Introduce Rlp::at_with_offset method. (#269) Make fixed-hash test structs public (#267) Migrate primitive types to 2018 edition (#262) upgrade tiny-keccak to 2.0 (#260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alloc is required by the
rustc-heximplementation which makes the build withdefault-featuresto fail.This commit re-exports
allocfor both std and no-std to fix this problem