Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
joao-paulo-parity committed Jan 10, 2022
1 parent 4e4fef5 commit 4166f1e
Showing 1 changed file with 12 additions and 8 deletions.
20 changes: 12 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ which will allow processbot to detect and disregard them.
A Pull Request needs either (meaning, only **one of** the following
requirements needs to be fulfilled)

- [core-dev](#core-devs) member approvals (2 for Substrate, 1 otherwise), or
- One [substrateteamleads](#substrateteamleads) member approval
- [core-dev](https://github.com/orgs/paritytech/teams/core-devs) member approvals (2 for Substrate, 1 otherwise), or
- One [substrateteamleads](https://github.com/orgs/paritytech/teams/substrateteamleads) member approval

This criteria strictly matters only for the bot's internal logic irrespective
of Github Repository Settings and will not trump the latter in any case. For
Expand All @@ -65,19 +65,23 @@ does not imply that the pull request will be mergeable if the Github Settings
require more approvals than that. The bot's rules work *in addition* to the
repository's settings while still respecting them. Specifically when it comes
to the approvals' count, however, the bot might able to help if a
[team lead](#substrateteamleads) is requesting the merge.
[team lead](https://github.com/orgs/paritytech/teams/substrateteamleads)
is requesting the merge.

When the bot is commanded to merge, if the PR is short of 1 approval and the
command's requester might not be able to fulfill the approval count on their
own, then the bot will try to pitch in the missing approval if the requester is
a [team lead](#substrateteamleads). The reasoning for this feature is as
follows:
a [team lead](https://github.com/orgs/paritytech/teams/substrateteamleads).
The reasoning for this feature is as follows:

1. PR authors cannot approve their own merge requests, although
[team leads](#substrateteamleads) should have the means to bypass that
requirement e.g. for trivial or urgent changes.
[team leads](https://github.com/orgs/paritytech/teams/substrateteamleads)
should have the means to bypass that requirement e.g. for trivial or urgent
changes.

2. If the [team lead](#substrateteamleads) has already approved and it's still
2. If the
[team lead](https://github.com/orgs/paritytech/teams/substrateteamleads)
has already approved and it's still
short of one, they cannot "approve twice" in order to meet the quota. In that
case, the bot should contribute one approval in order to help them meet that
requirement.
Expand Down

0 comments on commit 4166f1e

Please sign in to comment.