This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Mak/fix stg #409
Merged
Mak/fix stg #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mordamax
requested review from
paritytech-ci and
a team
and removed request for
paritytech-ci
alvicsam
approved these changes
Feb 10, 2023
rzadp
reviewed
Feb 10, 2023
| # remember initial branch | ||
| dev_branch=$(git rev-parse --abbrev-ref HEAD) | ||
|
|
||
| # replace possible "/" with "-" |
There was a problem hiding this comment.
Could you include a comment why it is done? Gitlab does not like / in branch names?
There was a problem hiding this comment.
This is not because of gitlab. The reason is docker. It uses git tag for tagging the image so if there's a / symbol docker thinks that it's actually a path. but not part of the tag name.
rzadp
reviewed
Feb 10, 2023
deploy-stg.sh
Outdated
| stg_branch="stg-v0.0.${timestamp}-${dev_branch_sanitized}" | ||
|
|
||
| git checkout -b "$stg_branch" | ||
| git push origin "$stg_branch" |
There was a problem hiding this comment.
Consider doing:
git push origin HEAD:"$stg_branch"
Then you could simplify the script by removing the git checkouts because a local branch is not needed then.
rzadp
reviewed
Feb 15, 2023
deploy-stg.sh
Outdated
| git push origin --delete "$stg_branch" | ||
|
|
||
| # get back to initial branch | ||
| git checkout "$dev_branch" |
rzadp
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
cumulus: https://github.com/paritytech-stg/cumulus/pull/2