Prevent serde from bringing in std unless the std feature is enab…

…led for this crate (#499)

* Prevent serde from bringing in `std` unless the `std` feature is enabled
for this crate.

* simplify serde usage

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>

Cargo.toml

@@ -11,7 +11,7 @@ rust-version = "1.60.0"
 
 [dependencies]
 arrayvec = { version = "0.7", default-features = false }
-serde = { version = "1.0.183", optional = true }
+serde = { version = "1.0.183", default-features = false, optional = true }
 parity-scale-codec-derive = { path = "derive", version = ">= 3.6.4", default-features = false, optional = true }
 bitvec = { version = "1", default-features = false, features = [ "alloc" ], optional = true }
 bytes = { version = "1", default-features = false, optional = true }
@@ -39,7 +39,7 @@ bench = false
 [features]
 default = ["std"]
 derive = ["parity-scale-codec-derive"]
-std = ["serde", "bitvec?/std", "byte-slice-cast/std", "chain-error"]
+std = ["serde/std", "bitvec?/std", "byte-slice-cast/std", "chain-error"]
 bit-vec = ["bitvec"]
 fuzz = ["std", "arbitrary"]
 

src/compact.rs

@@ -192,14 +192,14 @@ impl<T> core::fmt::Debug for Compact<T> where T: core::fmt::Debug {
  }
 }
 
-#[cfg(feature = "std")]
+#[cfg(feature = "serde")]
 impl<T> serde::Serialize for Compact<T> where T: serde::Serialize {
  fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error> where S: serde::Serializer {
  T::serialize(&self.0, serializer)
  }
 }
 
-#[cfg(feature = "std")]
+#[cfg(feature = "serde")]
 impl<'de, T> serde::Deserialize<'de> for Compact<T> where T: serde::Deserialize<'de> {
  fn deserialize<D>(deserializer: D) -> Result<Self, D::Error> where D: serde::Deserializer<'de> {
  T::deserialize(deserializer).map(Compact)