Commits on May 30, 2020

1. Use proper span when emitting 'self' identifier …

   Normally, the span of a field has the same hygiene context as
   `Span::call_site`. However, it's possible for a struct definition
   to be 'constructed' via a `macro_rules` macro such that the field
   has a different hygiene context. This will cause the expanded code
   to be unable to resolve any references to `self`, resulting in a
   compilation error.
   
   This pull request uses `quote!` instead of `quote_spanned!` when
   emitting a 'self' identifier. `quote_spanned!` is still used for
   everything else in the emitted method, meaning that error messages
   will still point to the proper field.
   
   I've included a test case which triggers this issue on
   Rust 1.43.1. It's current difficult to hit this issue
   other than in this artificial case, but that will change
   once rust-lang/rust#72622 is re-landed.

   

   Aaron1011 committed May 30, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 2431f7e
   • Browse repository at this point

   Copy the full SHA

   2431f7e View commit details

   Browse the repository at this point in the history