Support f32 and f64 when the full feature is enabled
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koute
requested review from
andresilva,
RGafiyatullin,
skunert,
bkchr,
davxy and
gui1117
bkchr
approved these changes
May 24, 2022
davxy
approved these changes
May 24, 2022
shawntabrizi
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds optional support for serializing/deserializing
f32andf64.Why?
We don't really need this (which is why it's disabled by default and only enabled when the
fullfeature is enabled), however supporting these takes very little effort, and I'd like to addparity-scale-codecto therust_serialization_benchmarkto see how it stacks up to other crates performance-wise, and those benchmark require the ability to serialize/deserializef32s.You can find limited benchmark results in this issue.