Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixing mutual recursive types serialization #1977

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Fixing mutual recursive types serialization #1977

merged 1 commit into from
Aug 23, 2016

Conversation

tomusdrw
Copy link
Collaborator

Fixes below error:

error[E0275]: overflow evaluating the requirement `v1::types::trace::VMOperation: serde::Serialize`
    --> /home/tomusdrw/eth/parity/dapps/target/release/build/ethcore-rpc-2826bc3b63de4723/out/mod.rs:3647:18
     |
3647 |             impl _serde::ser::Serialize for VMOperation where
     |                  ^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: required by `serde::Serialize`

error: aborting due to previous error

Issue: serde-rs/serde#441

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Aug 22, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 86.913% when pulling 3e3a08f on overflow-fix into f69b3f8 on master.

@keorn keorn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 22, 2016
@arkpar arkpar merged commit 6cb439f into master Aug 23, 2016
@tomusdrw tomusdrw deleted the overflow-fix branch August 24, 2016 10:52
debris pushed a commit that referenced this pull request Sep 1, 2016
debris pushed a commit that referenced this pull request Sep 1, 2016
arkpar pushed a commit that referenced this pull request Sep 1, 2016
arkpar pushed a commit that referenced this pull request Sep 5, 2016
* Fixing serde overflow error (#1977)

* updated secp library

* fixed issues with compiling ethjson
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants