This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
protection from adding empty traces && assertion in traces db #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 21ea121 on trace_db_assert into * on master*. |
| // invalid: retracted 1, enacted 0 => true, false, | ||
| let ret = request.retracted != 0; | ||
| let ena = !request.enacted.is_empty(); | ||
| assert!((!ret && ena) || (ret == ena)); |
There was a problem hiding this comment.
Wouldn't assert!(!(ret && !ena)); work and be more in-line to what is written in comment?
(if I understand correctly there is only one invalid case - ret == true && ena == false - so negation will cover all valid cases)
I'm I missing something?
tomusdrw
added
A6-mustntgrumble 💦
debris
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
|
Changes Unknown when pulling d7d9b23 on trace_db_assert into * on master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it may help diagnose #1971